Fix handling of theme change

[arjxn-py]

theme.mov

Shall close #480

[github-actions]

Preview PR at appsharing.space

[github-actions]

Integration tests repot: appsharing.space

[SylvainCorlay]

A full resize event would trigger a complete reflow of the page. Maybe just doing it on the view would be more economical.

Also, is the resize the only thing that triggers a redraw of the view?

[arjxn-py]

Also, is the resize the only thing that triggers a redraw of the view?

That sounds good, thanks @SylvainCorlay.
I at the moment can't think of any other way but I'm happy to discuss and iterate over it.

[SylvainCorlay]

Just calling update() on the Lumino panel of the 3-D view should do it. People more familiar with Lumino on the team will know the proper way to do.

[trungleduc]

you can use MessageLoop.sendMessage to send the Widget.ResizeMessage message to the 3D view widget.

JupyterCAD/packages/base/src/panelview/formbuilder.tsx

Line 37 in 7e6b49b

MessageLoop.sendMessage(widget, Widget.Msg.BeforeAttach);

[arjxn-py]

you can use MessageLoop.sendMessage to send the Widget.ResizeMessage message to the 3D view widget.

JupyterCAD/packages/base/src/panelview/formbuilder.tsx

Line 37 in 7e6b49b

MessageLoop.sendMessage(widget, Widget.Msg.BeforeAttach);

@trungleduc When i try MessageLoop.sendMessage in model.ts it says

Property 'sendMessage' does not exist on type 
'typeof import("/Users/arjunverma/Desktop/Arjun/JupyterCAD/node_modules/@lumino/messaging/types/index")'

but the same works in formbuilder.tsx

[martinRenou]

My 2 cents, we used to depend on the lightTheme attribute in the React component state to change the background color according to it: https://github.com/jupytercad/JupyterCAD/blob/main/packages/base/src/3dview/mainview.tsx#L1444

This seems to not be used anymore! So we should probably remove lightTheme from the state, but we should probably modify this _handleThemeChange method there to force a this.update() of the react component to trigger a re-render, instead of setting that old unused state attribute.

[martinRenou]

Neat! These are the best PRs