-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CONTRIBUTING.md with settings for yarn and npm #7100
Open
navdeepgill14
wants to merge
4
commits into
jupyter:main
Choose a base branch
from
navdeepgill14:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
30be4ed
Added "yarn" and "npm" steps in CONTRIBUTING.md
navdeepgill14 c2e33f6
Merge pull request #1 from navdeepgill14/navdeepgill14-patch-1
navdeepgill14 98a9d04
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] df4f992
Updated CONTRIBUTING.md based on PR feedback
navdeepgill14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with
mamba
, we still need to useyarn
ornpm
to work with the JavaScript dependencies.So maybe there could be a mention to creating environment
venv
after themamba
instructions, instead of repeating everything?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jtpio,
Thank you for your valuable feedback. I've addressed your comments and made the necessary changes to the documentation. You can find the new commit related to this feedback here: Updated CONTRIBUTING.md.
Please review the updated changes at your convenience. If everything looks good, I kindly request that you consider merging the pull request. If there are any further suggestions or if you have any concerns, please don't hesitate to let me know. Your feedback is greatly appreciated, and I'm here to ensure the documentation aligns with the project's standards.
Thanks again for your time and assistance.
Best regards,
Navdeep