Skip to content

Commit

Permalink
try fix flakyness
Browse files Browse the repository at this point in the history
  • Loading branch information
@jtpio
jtpio committed May 14, 2024
1 parent e9c1678 commit f9faf88
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ui-tests/test/mobile.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ test.describe('Mobile', () => {
await page.goto(`tree/${tmpPath}`);

// Create a new notebook
await page.click('text="New"');
const [notebook] = await Promise.all([
page.waitForEvent('popup'),

Check failure on line 48 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:38:7 › Mobile › The layout should be more compact on the notebook page 

  1) [chromium] › test/mobile.spec.ts:38:7 › Mobile › The layout should be more compact on the notebook page 
    Error: proxy.waitForEvent: Test timeout of 60000ms exceeded.
    =========================== logs ===========================
    waiting for event "popup"
    ============================================================

      46 |     await page.click('text="New"');
      47 |     const [notebook] = await Promise.all([
    > 48 |       page.waitForEvent('popup'),
         |            ^
      49 |       page.click('text="Python 3 (ipykernel)"'),
      50 |     ]);
      51 |

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:48:12

Check failure on line 48 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:38:7 › Mobile › The layout should be more compact on the notebook page 

  1) [chromium] › test/mobile.spec.ts:38:7 › Mobile › The layout should be more compact on the notebook page 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: proxy.waitForEvent: Test timeout of 60000ms exceeded.
    =========================== logs ===========================
    waiting for event "popup"
    ============================================================

      46 |     await page.click('text="New"');
      47 |     const [notebook] = await Promise.all([
    > 48 |       page.waitForEvent('popup'),
         |            ^
      49 |       page.click('text="Python 3 (ipykernel)"'),
      50 |     ]);
      51 |

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:48:12
page.click('text="New"'),
page.click('text="Python 3 (ipykernel)"'),
]);

Expand Down
2 changes: 1 addition & 1 deletion ui-tests/test/smoke.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ test.describe('Smoke', () => {
await console.waitForSelector('.jp-CodeConsole');

// Create a new notebook
await page.click('text="New"');
const [notebook] = await Promise.all([
page.waitForEvent('popup'),

Check failure on line 29 in ui-tests/test/smoke.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/smoke.spec.ts:10:7 › Smoke › Tour 

  2) [chromium] › test/smoke.spec.ts:10:7 › Smoke › Tour ───────────────────────────────────────────
    Error: proxy.waitForEvent: Test timeout of 60000ms exceeded.
    =========================== logs ===========================
    waiting for event "popup"
    ============================================================

      27 |     await page.click('text="New"');
      28 |     const [notebook] = await Promise.all([
    > 29 |       page.waitForEvent('popup'),
         |            ^
      30 |       page.click('text="Python 3 (ipykernel)"'),
      31 |     ]);
      32 |

        at /home/runner/work/notebook/notebook/ui-tests/test/smoke.spec.ts:29:12

Check failure on line 29 in ui-tests/test/smoke.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/smoke.spec.ts:10:7 › Smoke › Tour 

  2) [chromium] › test/smoke.spec.ts:10:7 › Smoke › Tour ───────────────────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: proxy.waitForEvent: Test timeout of 60000ms exceeded.
    =========================== logs ===========================
    waiting for event "popup"
    ============================================================

      27 |     await page.click('text="New"');
      28 |     const [notebook] = await Promise.all([
    > 29 |       page.waitForEvent('popup'),
         |            ^
      30 |       page.click('text="Python 3 (ipykernel)"'),
      31 |     ]);
      32 |

        at /home/runner/work/notebook/notebook/ui-tests/test/smoke.spec.ts:29:12
page.click('text="New"'),
page.click('text="Python 3 (ipykernel)"'),
]);

Expand Down

0 comments on commit f9faf88

Please sign in to comment.