Skip to content

Add missing "Open..." file menu (#7385) #2057

Add missing "Open..." file menu (#7385)

Add missing "Open..." file menu (#7385) #2057

Triggered via push May 31, 2024 13:10
Status Failure
Total duration 10m 49s
Artifacts 7

ui-tests.yml

on: push
Matrix: ui-tests
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 3 notices
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L1
1) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Test timeout of 60000ms exceeded.
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L25
1) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Error: proxy.waitForEvent: Test timeout of 60000ms exceeded. =========================== logs =========================== waiting for event "popup" ============================================================ 23 | 24 | const [current] = await Promise.all([ > 25 | page.waitForEvent('popup'), | ^ 26 | page.getByText('Current Directory').last().click(), 27 | ]); 28 | at /home/runner/work/notebook/notebook/ui-tests/test/links.spec.ts:25:12
[chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible: ui-tests/test/notebook.spec.ts#L1
2) [chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible ─ Error: apiRequestContext.fetch: Test ended. Call log: - → POST http://localhost:8888/api/sessions?1717161479659 - user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/125.0.6422.26 Safari/537.36 - accept: */* - accept-encoding: gzip,deflate,br - accept-language: en-US - content-type: text/plain;charset=UTF-8 - cookie: username-localhost-8888="2|1:0|10:1717161477|23:username-localhost-8888|196:eyJ1c2VybmFtZSI6ICJlMmYwOWZlYjQ3ODA0MjY5OGU5MThhYmM0MWQ4NWM0YSIsICJuYW1lIjogIkFub255bW91cyBFdXJvcGEiLCAiZGlzcGxheV9uYW1lIjogIkFub255bW91cyBFdXJvcGEiLCAiaW5pdGlhbHMiOiAiQUUiLCAiY29sb3IiOiBudWxsfQ==|df36ffaf8730b7ecd578b2556c684729e9222034d4dc104f4bf7c5bd3ed0269b"; _xsrf=2|a43b2238|81b67ccfe1a56802aaa6966d3a119f33|1717161477 - origin: http://localhost:8888 - referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-chromium/example.ipynb - x-xsrftoken: 2|a43b2238|81b67ccfe1a56802aaa6966d3a119f33|1717161477 - sec-ch-ua: "HeadlessChrome";v="125", "Chromium";v="125", "Not.A/Brand";v="24" - sec-ch-ua-mobile: ?0 - sec-ch-ua-platform: "Linux" - content-length: 173 at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:925:49
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ──────────────────── Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ──────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page: ui-tests/test/mobile.spec.ts#L71
2) [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Error: Screenshot comparison failed: 300 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox/notebook-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox/notebook-diff.png 69 | } 70 | > 71 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); | ^ 72 | await notebook.close(); 73 | }); 74 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:71:41
[firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page: ui-tests/test/mobile.spec.ts#L71
2) [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 300 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox-retry1/notebook-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox-retry1/notebook-diff.png 69 | } 70 | > 71 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); | ^ 72 | await notebook.close(); 73 | }); 74 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:71:41
[firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder: ui-tests/test/filebrowser.spec.ts#L28
3) [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 26 | 27 | expect(toolbar.getByText('Rename')).toBeVisible(); > 28 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 29 | }); 30 | 31 | test('Select one file', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:28:41
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
4) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Open') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Open') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
5) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
ui-tests (firefox)
Process completed with exit code 1.
🎭 Playwright Run Summary
2 flaky [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ──────────────── [chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible ── 33 passed (2.1m)
🎭 Playwright Run Summary
35 passed (1.9m)
🎭 Playwright Run Summary
2 failed [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ───────────────────── [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 3 flaky [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ─────────────────── [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── 30 passed (2.3m)

Artifacts

Produced during runtime
Name Size
notebook-chromium-test-assets Expired
5.24 MB
notebook-chromium-test-report Expired
5.88 MB
notebook-dist-2057 Expired
10.5 MB
notebook-firefox-test-assets Expired
3.95 MB
notebook-firefox-test-report Expired
4.53 MB
notebook-firefox-updated-snapshots Expired
360 KB
notebook-pkgs-2057 Expired
56.9 KB