Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pythons in CI #723

Merged
merged 14 commits into from
Dec 12, 2021
Merged

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Dec 12, 2021

Binder

References

Code changes

  • deps: updates python_requires to 3.7
  • CI: normalizes CPython versions under test to 3.7 and 3.10
    • might need to roll back top to 3.9 for solveability
    • add r 4.* and 3.* to matrix
    • share node_modules cache between build and lint
  • docs: updates readthedocs to use new environment configuration
    • uses docker image pre-loaded with mambaforge

User-facing changes

  • n/a

Backwards-incompatible changes

  • users on python 3.6 will be unable to upgrade to future versions

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch bollwyvl/jupyterlab-lsp/gh-718-ci-pythons

@bollwyvl bollwyvl changed the title Gh 718 ci pythons Update Pythons in CI Dec 12, 2021
@bollwyvl
Copy link
Collaborator Author

Looks like 3.10 is a no-go for.... reasons:

package r-recommended-3.3.2-r3.3.2_0 requires r-base 3.3.2, but none of the providers can be installed

@bollwyvl
Copy link
Collaborator Author

Anecdata: the RTD build took 252 seconds, vs 274 for master

@krassowski
Copy link
Member

Is probably safe to witch R to 4.0 maybe even 4.1. Would that help?

@bollwyvl
Copy link
Collaborator Author

R to 4.0 maybe even 4.1

Sure' maybe worth trying...

@bollwyvl bollwyvl marked this pull request as ready for review December 12, 2021 20:09
@bollwyvl
Copy link
Collaborator Author

All of the acceptance tests have run to completion at least once, so I don't see why this wouldn't work, now. Still checking out binder, but otherwise fairly happy with the changes.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@krassowski krassowski merged commit 8d904f9 into jupyter-lsp:master Dec 12, 2021
@bollwyvl
Copy link
Collaborator Author

Whoops, on master CI:

 Invalid workflow file

The workflow is not valid. .github/workflows/job.test.yml (Line: 16, Col: 10): Unexpected value ''

@krassowski
Copy link
Member

@bollwyvl
Copy link
Collaborator Author

Hotfixed on e83d8e6, but still need to see if that's the right thing to have done. Basically, want to only be running one set of jobs per PR...

@krassowski
Copy link
Member

So that issue I linked to was resolved: actions/runner#1532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.6, start testing a newer version, restore MacOS to latest
2 participants