-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pythons in CI #723
Update Pythons in CI #723
Conversation
👈 Launch a binder notebook on branch bollwyvl/jupyterlab-lsp/gh-718-ci-pythons |
Looks like
|
Anecdata: the RTD build took 252 seconds, vs 274 for |
Is probably safe to witch R to 4.0 maybe even 4.1. Would that help? |
Sure' maybe worth trying... |
All of the acceptance tests have run to completion at least once, so I don't see why this wouldn't work, now. Still checking out binder, but otherwise fairly happy with the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Whoops, on master CI:
|
Hotfixed on e83d8e6, but still need to see if that's the right thing to have done. Basically, want to only be running one set of jobs per PR... |
So that issue I linked to was resolved: actions/runner#1532 |
References
Code changes
python_requires
to 3.7might need to roll back top to 3.9 for solveabilityr
4.* and 3.* to matrixnode_modules
cache betweenbuild
andlint
User-facing changes
Backwards-incompatible changes
Chores