Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostic listing sorting by cell/line, fix header border #717

Merged
merged 5 commits into from
Dec 11, 2021

Conversation

krassowski
Copy link
Member

References

Fixes #707

Code changes

Improved sorting, added test.

User-facing changes

Before:

Screenshot from 2021-12-11 16-29-28

After:

Screenshot from 2021-12-11 16-27-35

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jupyter-lsp/jupyterlab-lsp/fix-diagnostic-listing

@krassowski
Copy link
Member Author

MacOS builds are failing due to an upgrade of macos-latest on GitHub Actions, pinning to the previous version for now. I opened:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting by Line:Ch in Diagnostics Panel does not work
1 participant