Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ fix/direct import bug #757

Merged
merged 3 commits into from
Jul 19, 2024
Merged

🛠️ fix/direct import bug #757

merged 3 commits into from
Jul 19, 2024

Conversation

stevejpurves
Copy link
Collaborator

Fixes a cross package import from core into react the broke downstream SSR!

Copy link
Contributor

github-actions bot commented Jul 19, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-19 22:00 UTC

@stevejpurves stevejpurves merged commit 95eb9b5 into main Jul 19, 2024
3 checks passed
@stevejpurves stevejpurves deleted the fix/direct-import-bug branch July 19, 2024 21:57
stevejpurves added a commit that referenced this pull request Sep 5, 2024
stevejpurves added a commit that referenced this pull request Sep 5, 2024
* Revert "🛠️ fix/direct import bug (#757)"

This reverts commit 95eb9b5.

* Revert "passive thebe manager (#756)"

This reverts commit 30f569e.

* 📘 changeset
stevejpurves added a commit that referenced this pull request Sep 5, 2024
* ✨keep types pure

* 🙈 don't import objects from core to react

* 📗changeset
stevejpurves added a commit that referenced this pull request Sep 5, 2024
* ✨keep types pure

* 🙈 don't import objects from core to react

* 📗changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant