Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⌨️ Add keyboard support to myst-to-html #1677

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Nov 26, 2024

Addresses a sub-issue in #1676 for HTML exports of keyboard nodes.

I only test the hast here, because we should be able to rely on the ecosystem tests for hast-to-html imo.

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 58fe94a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
myst-to-html Patch
myst-transforms Patch
myst-parser Patch
myst-roles Patch
myst-directives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agoose77 agoose77 requested a review from fwkoch November 26, 2024 11:43
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

packages/myst-to-html/package.json Show resolved Hide resolved
@rowanc1
Copy link
Member

rowanc1 commented Nov 26, 2024

I think moving to yaml based tests in the future might be better! Doesn't need to happen now.

@agoose77 agoose77 merged commit a27bd88 into main Nov 26, 2024
7 checks passed
@agoose77 agoose77 deleted the agoose77/fix-kbd-html-export branch November 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants