Merge pull request #35 from curvenote/feat/frontmatter-subject

Front Matter - Subject
jupyter-book · May 27, 2022 · 6c58384 · 6c58384
2 parents 637694d + 57162ec
commit 6c58384
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/blocks/types/frontMatter.ts b/src/blocks/types/frontMatter.ts
@@ -11,6 +11,7 @@ export type FrontMatterProps = {
   open_access: boolean | null;
   github: string | null;
   binder: string | null;
+  subject: string | null;
   subtitle: string | null;
   short_title: string | null;
   venue: { title?: string; url?: string } | null;
@@ -24,7 +25,7 @@ export type FrontMatterProps = {
 
 export type BlockFrontMatterProps = Partial<FrontMatterProps>;
 
-export type ProjectFrontMatterProps = Omit<BlockFrontMatterProps, 'venue' | 'biblio'>;
+export type ProjectFrontMatterProps = Omit<BlockFrontMatterProps, 'venue' | 'biblio' | 'subtitle'>;
 
 // Exhausiveness is ensured in test
 export const PROJECT_FRONT_MATTER_KEYS = [
@@ -35,12 +36,13 @@ export const PROJECT_FRONT_MATTER_KEYS = [
   'open_access',
   'github',
   'binder',
-  'subtitle',
+  'subject',
   'short_title',
 ] as (keyof ProjectFrontMatterProps)[];
 
 export const BLOCK_FRONT_MATTER_KEYS = [
   ...PROJECT_FRONT_MATTER_KEYS,
   'venue',
   'biblio',
+  'subtitle',
 ] as (keyof BlockFrontMatterProps)[];
diff --git a/src/blocks/utils.spec.ts b/src/blocks/utils.spec.ts
@@ -8,7 +8,6 @@ export const TEST_PROJECT_FRONT_MATTER: ProjectFrontMatterProps = {
   open_access: false,
   github: '',
   binder: '',
-  subtitle: '',
   short_title: '',
 };
 
@@ -39,14 +38,15 @@ describe('extractBlockFrontMatter', () => {
       arxiv: 'arxiv',
       binder: 'binder',
       subtitle: 'subtitle',
+      subject: 'subject',
       short_title: '',
       open_access: false,
       venue: {},
       biblio: {},
     };
 
     expect(extractBlockFrontMatter(frontmatter)).toEqual(frontmatter);
-    const { venue, biblio, ...projectExtractionResult } = frontmatter;
+    const { venue, biblio, subtitle, ...projectExtractionResult } = frontmatter;
     expect(extractProjectFrontMatter(frontmatter)).toEqual(projectExtractionResult);
   });