🌠 Support favicon in static builds (#1565)

Fixes #1449
jupyter-book · Oct 4, 2024 · 40ea2dd · 40ea2dd
1 parent c6b63a0
commit 40ea2dd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.changeset/red-swans-remain.md b/.changeset/red-swans-remain.md
@@ -0,0 +1,5 @@
+---
+"myst-cli": patch
+---
+
+Fix favicon writing
diff --git a/packages/myst-cli/src/build/html/index.ts b/packages/myst-cli/src/build/html/index.ts
@@ -81,10 +81,9 @@ function rewriteAssetsFolder(directory: string, baseurl?: string): void {
     }
     if (!['.html', '.js', '.json'].includes(path.extname(file))) return;
     const data = fs.readFileSync(file).toString();
-    const modified = data.replace(
-      new RegExp(`\\/${ASSETS_FOLDER}\\/`, 'g'),
-      `${baseurl || ''}/build/`,
-    );
+    const modified = data
+      .replace(new RegExp(`\\/${ASSETS_FOLDER}\\/`, 'g'), `${baseurl || ''}/build/`)
+      .replace('href="/favicon.ico"', `href="${baseurl || ''}/favicon.ico"`);
     fs.writeFileSync(file, modified);
   });
 }