Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Change favicon rewrite to be build-time #494

Merged
merged 1 commit into from
Nov 6, 2024
Merged

🐛 Change favicon rewrite to be build-time #494

merged 1 commit into from
Nov 6, 2024

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Nov 6, 2024

When loading the config.json to locate the favicon, we are preparing URLs to be resolved in the statically built context. However, we're consuming the links at build time, so we should not do this.
-- @agoose77

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: fac1f6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@myst-theme/article Patch
@myst-theme/book Patch
@myst-theme/providers Patch
@myst-theme/frontmatter Patch
@myst-theme/diagrams Patch
@myst-theme/jupyter Patch
@myst-theme/site Patch
@myst-theme/styles Patch
@myst-theme/common Patch
@myst-theme/icons Patch
@myst-theme/search Patch
@myst-theme/search-minisearch Patch
myst-to-react Patch
myst-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rowanc1 rowanc1 merged commit fde7014 into main Nov 6, 2024
2 checks passed
@rowanc1 rowanc1 deleted the feat/favicon branch November 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant