fix(list-slider): add touchmove listener to identifies move #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brunosf
changed the title
brunosf
changed the title
tassioFront
reviewed
Sep 5, 2024
tassioFront
reviewed
Sep 5, 2024
felipefialho
approved these changes
Sep 9, 2024
MayaraRMA
approved these changes
Sep 9, 2024
tassioFront
approved these changes
Sep 10, 2024
brunosf
deleted the
fix/moving-to-first-position-on-touch-inner-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
What impacts?
May impact the behavior of changing the position of items within the list-slider component
Reversal plan
Return previous version in NPM and rollback this PR
Evidences
Before
mobile-error.mp4
After
mobile-ok.mp4