-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): add modal component #534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipefialho
changed the title
feat(modal): modal component
feat(modal): add modal component
Aug 13, 2024
|
igorwessel
requested changes
Aug 13, 2024
gabrielduete
previously approved these changes
Aug 13, 2024
lupy100
suggested changes
Aug 13, 2024
lupy100
previously approved these changes
Aug 14, 2024
felipefialho
previously approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
igorwessel
previously approved these changes
Aug 14, 2024
tassioFront
reviewed
Aug 14, 2024
tassioFront
reviewed
Aug 14, 2024
matheus-rosa-jsm
dismissed stale reviews from igorwessel and felipefialho
via
August 15, 2024 12:06
8f6b550
tassioFront
approved these changes
Aug 15, 2024
felipefialho
approved these changes
Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal component
Task
Issue
Figam
closes #99
What is being delivered?
New component that wrap ion-modal component.
What impacts?
Reversal plan
Describe which plan we should follow if this delivery has to be reversed.
Evidences
Media(images, gifs or videos) that shows the result of your work.