Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal): add modal component #534

Merged
merged 14 commits into from
Aug 16, 2024
Merged

feat(modal): add modal component #534

merged 14 commits into from
Aug 16, 2024

Conversation

matheus-rosa-jsm
Copy link
Contributor

@matheus-rosa-jsm matheus-rosa-jsm commented Aug 13, 2024 •
edited by felipefialho
Loading

Modal component

Task
Issue
Figam

closes #99

What is being delivered?

New component that wrap ion-modal component.

What impacts?

  • New storybook template to not render the component twice.
  • Button with part property to facilitate web-component customization

Reversal plan

Describe which plan we should follow if this delivery has to be reversed.

Evidences

Media(images, gifs or videos) that shows the result of your work.
image
image
image
image
image
image

@matheus-rosa-jsm matheus-rosa-jsm self-assigned this Aug 13, 2024
@felipefialho felipefialho changed the title feat(modal): modal component feat(modal): add modal component Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-16 16:40 UTC

@matheus-rosa-jsm matheus-rosa-jsm mentioned this pull request Aug 13, 2024
Open
gabrielduete
gabrielduete previously approved these changes Aug 13, 2024
View reviewed changes
packages/core/src/components.d.ts Show resolved Hide resolved
@gabrielduete gabrielduete self-requested a review August 13, 2024 20:44
lupy100
lupy100 previously approved these changes Aug 14, 2024
View reviewed changes
felipefialho
felipefialho previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@felipefialho felipefialho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

igorwessel
igorwessel previously approved these changes Aug 14, 2024
View reviewed changes
@matheus-rosa-jsm matheus-rosa-jsm merged commit f3fc1bb into main Aug 16, 2024
2 checks passed
@matheus-rosa-jsm matheus-rosa-jsm deleted the feat/modal-component branch August 16, 2024 16:37
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipefialho felipefialho felipefialho approved these changes

@tassioFront tassioFront tassioFront approved these changes

@gabrielduete gabrielduete Awaiting requested review from gabrielduete

@lupy100 lupy100 Awaiting requested review from lupy100

@igorwessel igorwessel Awaiting requested review from igorwessel

Assignees

@matheus-rosa-jsm matheus-rosa-jsm

Labels
components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Dialog/Modal
6 participants
@matheus-rosa-jsm @felipefialho @lupy100 @tassioFront @igorwessel @gabrielduete