Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to Truth docs instead of GitHub landing page. #1953

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Link to Truth docs instead of GitHub landing page. #1953

merged 1 commit into from
Jul 10, 2019

Conversation

cpovirk
Copy link
Contributor

@cpovirk cpovirk commented Jul 9, 2019

I hereby agree to the terms of the JUnit Contributor License Agreement.

marcphilipp
marcphilipp approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the 1.0 release! 👍

@marcphilipp marcphilipp merged commit 0ebb3bb into junit-team:master Jul 10, 2019
@marcphilipp marcphilipp added this to the 5.6 M1 milestone Jul 10, 2019
@sormuras
Copy link
Member 

java PresentModule.java com.google.truth:truth:1.0
path = truth-1.0.jar
name = truth
mode = automatic
automatic name source = FILENAME
api = 1 package(s)

Not providing an AUTOMATIC-MODULE-NAME, like com.google.truth via its manifest...

@marcphilipp
Copy link
Member

@sormuras Sounds like you should create an issue in Truth's issue tracker. 😉

@sormuras
Copy link
Member

Truth.

Erm... true.

@sormuras
Copy link
Member

Done via google/truth#605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees
No one assigned
Labels
theme: documentation type: enhancement
Projects
None yet
Milestone
5.6 M1
Development

Successfully merging this pull request may close these issues.
3 participants
@cpovirk @sormuras @marcphilipp