Summary #183
Open
Summary #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 86.32% 82.16% -4.17%
==========================================
Files 12 13 +1
Lines 775 824 +49
==========================================
+ Hits 669 677 +8
- Misses 106 147 +41
Continue to review full report at Codecov.
|
blueyed
force-pushed
the
summary
branch
2 times, most recently
from
d0ec6c5
to
d6282ea
Compare
This wraps the temporary script into a function to get the line number of `vader#assert` calls.
E.g.
( 1/13) [EXECUTE] (X) Vim(finish):E168: :finish used outside of a sourced file
> /home/user/src/neomake/tests/utils.vader:11: finish " foo
Also passes it through to `s:execute`.
This will use the actual file name for included lines. Fixes junegunn#88.
Wrapping the code in a function will cause them to not be available otherwise, or g:SyntaxAt() would have to be used.
While this means more overhead in general, it allows to access script-local variables in the tests. squash! FEAT: move s:prepare into vader#window#execute Use `vader#log` directly instead of `:Log`, since the latter might not be defined (yet).
This not only avoids multiple calls to `tempname()`, but makes Vim use the same script ID also when not run in Docker. For some reason it uses a new script ID (`<SID>`/`<SNR>`) when run normally, but uses the same ID when run in Docker. This means that the `!` with `function! s:vader_wrapper()` was not required in an environment that behaves like running it in Docker (with Neomake's tests). This also removes the `delete()`, which is handled by Vim itself when shutting down.
Vim does not generate profiling information for dict functions when the dict is local-scoped, since it apparently gets garbage collected automatically. Works around vim/vim#2350.
This is relevant for when `Include` is used. This is a breaking change, although the doc is not clear about it: > The path of the current `.vader` file can be accessed via `g:vader_file`.
`v:throwpoint` is empty in the first case.
Use g:vader_current_file instead.
This reverts commit 809e10c.
This gets handled by Vim automatically, and works around making Docker use the same inode or something similar (vim/vim#3353).
This is supported with Vim patch v8.1.0362.
TODO: - [ ] make this optional? - [ ] adjust README - [ ] add tests?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes/based on #107.
TODO: