Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vader#assert#diff to describe differences in lists/dicts #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Mar 11, 2017

I came up with this when comparing location/quickfix list entries.

It should get renamed probably, and then used by the assertion functions (at least assert_equal itself).

Ref: #120 (comment)

@junegunn
Copy link
Owner

Sorry for the delay. I had a crazy week and was completely exhausted.

It should get renamed probably, and then used by the assertion functions

Are you planning to do this?

@blueyed
Copy link
Collaborator Author

blueyed commented Apr 21, 2017

It should get renamed probably

Any suggestions for a better-fitting name?

@junegunn
Copy link
Owner

junegunn commented Apr 21, 2017

Maybe it's just okay as it is as it's an internal function. We can change it later if we want.

@codecov-io
Copy link

codecov-io commented Mar 25, 2018

Codecov Report

Merging #123 into master will decrease coverage by 3.87%.
The diff coverage is 2.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #123      +/-   ##
=========================================
- Coverage   83.37%   79.5%   -3.88%     
=========================================
  Files          12      12              
  Lines         734     771      +37     
=========================================
+ Hits          612     613       +1     
- Misses        122     158      +36
Flag Coverage Δ
#nvim 78.98% <2.7%> (-3.85%) ⬇️
#vim 79.24% <2.7%> (-3.86%) ⬇️
Impacted Files Coverage Δ
autoload/vader/assert.vim 57.3% <2.7%> (-38.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21639d9...5680800. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants