fix: public playbook variables are not displayed by other users #4449
Conversation
| }, | ||
| disableEdit: { | ||
| type: Boolean, | ||
| default: false | ||
| } | ||
| }, | ||
| data() { |
There was a problem hiding this comment.
It seems there is no code provided to analyze the differences between two versions. Please upload or share the specific code you would like me to compare and analyze.
| @@ -299,6 +299,9 @@ export default { | |||
| return editor.value !== editor.originValue | |||
| }, | |||
| setVariable(variables) { | |||
| if (this.disableEdit) { | |||
| return | |||
| } | |||
| this.$axios.patch(`/api/v1/ops/playbooks/${this.object.id}/`, | |||
| { variable: variables }).catch(err => { | |||
| this.$message.error(this.$tc('UpdateErrorMsg') + ' ' + err) | |||
There was a problem hiding this comment.
I did not execute the script you posted, but based on the code snippet that I've been able to analyze with minimal knowledge up until 2021-09-01, it does seem somewhat clean except perhaps for minor typos such as:
- Line 35: Remove "variable", it is already used.
However, please note the provided information pertained to my current capacity and cannot be applied retroactively nor should it be taken as official AI expertise. The accuracy of the analysis depends directly on whether the actual code complies with best practices today and also takes into account future security vulnerabilities which are outside the scope of the information available now in regards post my training year.
|
fix: public playbook variables are not displayed by other users