Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] restructure the Parallelism tutorial and add section on model building #3897

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[docs] restructure the Parallelism tutorial and add section on model building #3897

wants to merge 3 commits into from
+183 −122

Conversation

odow
Copy link
Member

@odow odow commented Dec 2, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (488a0db) to head (56162bb).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3897   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          43       43           
  Lines        6043     6043           
=======================================
  Hits         6018     6018           
  Misses         25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joaquimg
joaquimg reviewed Dec 2, 2024
View reviewed changes
docs/src/tutorials/algorithms/parallelism.md
Threads.@threads for i in 1:10
con = @build_constraint(x[i] <= i)
Threads.lock(my_lock) do
add_constraint(model, con)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this preserve determinism in the constraint order?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

docs/src/tutorials/algorithms/parallelism.md Outdated Show resolved Hide resolved
docs/src/tutorials/algorithms/parallelism.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimg joaquimg joaquimg left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @joaquimg