Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF7: Add native support for japanese text rendering #737

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CosmosXIII
Copy link
Contributor

@CosmosXIII CosmosXIII commented Sep 28, 2024

Summary

Adds an option to enable japanese text rendering for the japanese version of the game.
Right now field text only works if the jp flevel is re-exported using Makou Reactor.

Related #39

Motivation

To end the pain of the japanese nation.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

Changelog.md Outdated Show resolved Hide resolved
@julianxhokaxhiu
Copy link
Owner

Tested the PR on top of the native Japanese eStore release and first of all, well done :) I'm really impressed by this achievement!
I mainly noticed some bugs while using it, at least visually, I'll try to list them here so we can have a look together on how to fix it in case.

  1. Save slots are not aligned with the hand, here an example:
    JA:
    image
    EN:
    image

  2. Location text seems to be wrong/broken(?) I can see this in both save menu as well as in-game menu:
    image
    image

  3. Loading text seems also to be broken(?)
    image

I'm not sure if the context of those makes sense as I don't know the language, so any help on your side to check that is appreciated :)

Thanks a lot and looking forward to this really promising PR!

P.S.: I changed a bit the logic on how we enable this layer. Your original flag has been removed in favour of ff7_japanese_edition as it was already there since the beginning of the code, and we auto-enable it when we detected the japanese version of the game. However I left it also as a flag in the toml in case we might need to enable this manually because the auto-detection fails. Hope this is fine for you, let me know in case. Finally, I updated a bit the changelog message to fix the overall mission of this PR, let me know what you think.

@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Sep 28, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.21.0 milestone Sep 28, 2024
@julianxhokaxhiu julianxhokaxhiu changed the title FF7: Added option for japanese text rendering FF7: Add support for native japanese text rendering Sep 28, 2024
@julianxhokaxhiu julianxhokaxhiu changed the title FF7: Add support for native japanese text rendering FF7: Add native support for japanese text rendering Sep 28, 2024
@CosmosXIII
Copy link
Contributor Author

CosmosXIII commented Sep 28, 2024

Thanks for testing it.

  1. Save slots are not aligned with the hand

For the iro I was replacing the exe text with hext so I just added a few spaces to fix this.
By the way, the english exe text also has 3 spaces after each "Save x"
I'm not sure why but the japanese one did not have spaces so my guess is they hardcoded the spacing somewhere in code...

  1. Location text seems to be wrong/broken(?)

I think this is because of the broken flevel. Once I fixed that with Makou the location also worked fine for me.
Also the saves have to be new because this text gets stored in the save file so loading an english save file will have broken text.

  1. Loading text seems also to be broken(?)

The text here actually is correct but it's going outside the box.
So I think the fix here is to resize the box so that it fits the text but no idea where this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants