Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pause feature #994

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fumin65
Copy link

@fumin65 fumin65 commented Mar 21, 2024

related to #195

This PR introduces a pause feature.
pause() method stops the camera, but does not release the texture.
And It takes the following state transitions.

stateDiagram-v2
    [*] --> Start
    Start --> Pause
    Pause --> Start
    Pause --> Stop
    Start --> Stop
    Stop --> [*]
Loading

If this feature is useful and fits the concept of this library, please consider merging it.

@navaronbracke
Copy link
Collaborator

Thanks for the contribution! I don't yet have time for a full review (I will see if I can get that sorted in the coming week), but could you look into the following as well?

  1. Can we implement pause for MacOS too, since it is similar to iOS?
  2. Can we implement pause for the web? Not sure if the MediaStream would support this

@fumin65
Copy link
Author

fumin65 commented Mar 23, 2024

Thanks for your reply.
I will try these for now.
However, I am new to MacOS and MediaStream, so it will probably take some time.

@fumin65
Copy link
Author

fumin65 commented Apr 1, 2024

@navaronbracke I implemented pause for MacOS and web.
Please review if you have time.

@habibasseiss
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants