WIP Switch to iOS 13, use Tasks to handle threads and add error handling #726
Conversation
| throw MobileScannerError.noCamera | ||
| } | ||
|
|
||
| return MobileScannerStartParameters( |
There was a problem hiding this comment.
Does this return on the main dispatch queue still?
|
@ened Is there a reason why this was closed? It seems to be a nice improvement to have anyway. |
|
Happy to take another look. Closed it due to bug fix already in repo (for the iOS crashes). |
|
@ened Is this still on your radar? This might help with fixing another case of #720 occurring (not sure though). Unfortunately, there have been some changes to the iOS side of the plugin that caused some merge conflicts. I can take a look at this as well if needed. |
|
Hi all, since this PR is stale, i am going to merge it in to one of our branches so we don't alter the origin of @ened. This plugin still needs to support iOS 12, however async does support iOS 12. So i am going to change and test this, and merge if everything works out fine. Source: https://developer.apple.com/documentation/network/nwprotocolframer/instance/3200472-async Thanks for your work @ened ! |
juliansteenbakker
merged commit e59326b
into
juliansteenbakker:swift-async
No description provided.