Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump android dependency & clean up scanner widgets #1235

Merged
merged 18 commits into from
Nov 13, 2024
Merged

feat: bump android dependency & clean up scanner widgets #1235

merged 18 commits into from
Nov 13, 2024

Conversation

navaronbracke
Copy link
Collaborator

@navaronbracke navaronbracke commented Nov 7, 2024 •
edited
Loading

This PR:

  • fixes an odd bug in the iOS / MacOS implementation
  • updates API documentation
  • updates the barcode overlay / scan window overlay with extra styling properties

TODO: fix flickering bug with the overlay in the scanner overlay painter
TODO: fix barcode painter not repainting with no square when the barcode is no longer within the camera view

navaronbracke
navaronbracke commented Nov 7, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
analysis_options.yaml Show resolved Hide resolved
darwin/mobile_scanner/Sources/mobile_scanner/MobileScannerPlugin.swift Show resolved Hide resolved
lib/src/overlay/scan_window_overlay.dart Show resolved Hide resolved
lib/src/overlay/scan_window_painter.dart Show resolved Hide resolved
lib/src/overlay/scan_window_painter.dart Show resolved Hide resolved
lib/src/overlay/scan_window_painter.dart Show resolved Hide resolved
lib/src/overlay/scan_window_painter.dart Show resolved Hide resolved
@navaronbracke navaronbracke marked this pull request as draft November 9, 2024 15:27
@juliansteenbakker juliansteenbakker marked this pull request as ready for review November 13, 2024 08:08
@juliansteenbakker juliansteenbakker changed the base branch from ios-vision to ios-vision-update November 13, 2024 08:14
juliansteenbakker
juliansteenbakker approved these changes Nov 13, 2024
View reviewed changes
Copy link
Owner

@juliansteenbakker juliansteenbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I will merge this in a sub branch of ios-vision, and resolve the last two TODOs today. Then i will release a new beta version.

@juliansteenbakker juliansteenbakker merged commit d4d52ad into juliansteenbakker:ios-vision-update Nov 13, 2024
6 checks passed
@navaronbracke navaronbracke deleted the bump_android_barcode_scanning branch November 13, 2024 08:15
@navaronbracke
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliansteenbakker juliansteenbakker juliansteenbakker approved these changes

Assignees

@navaronbracke navaronbracke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navaronbracke @juliansteenbakker