Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump MLKit to 7.0.0 #1206

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

navaronbracke
Copy link
Collaborator

This PR updates MLKit to the latest release, which fixes dependency issues with other dependencies, such as Firebase.

However, due to MLKit requirements, the iOS minimum deployment target has been changed from 12.0 to 15.5.0.

See https://developers.google.com/ml-kit/release-notes#improvements for context.

Fixes #1165

@navaronbracke
Copy link
Collaborator Author

cc @juliansteenbakker for second thought on the version number. We do need to update the minimum iOS version here.

@juliansteenbakker
Copy link
Owner

I would prefer a new major version, since this is a breaking change. People that have pinned older versions of firebase could still use the current version without problems. So if we publish this as 5.2.4 or 5.3.0, we would break those instances.

On the other hand, lots of builds are failing right now, and if we publish this as a major version, a regular flutter pub upgrade would not fix this. So im not really sure what to do..

@juliansteenbakker
Copy link
Owner

Because this only affects people using firebase_ packages, lets stick to a new major version 6.0.0. People without firebase_ packages won't be affected by the issue, and this update could break that.

@navaronbracke
Copy link
Collaborator Author

@juliansteenbakker Agreed, updated the version to 6.0.0 and also added a note about the minimum XCode version in the changelog. (is mentioned in the MLKit release notes)

@juliansteenbakker
Copy link
Owner

Great! LGTM!

@navaronbracke navaronbracke merged commit 02e4c66 into juliansteenbakker:master Oct 7, 2024
4 checks passed
@navaronbracke navaronbracke deleted the mlkit_deps branch October 7, 2024 18:17
@creativecreatorormaybenot

@navaronbracke Thanks for your work! Will the new version be published to Pub today?

@navaronbracke
Copy link
Collaborator Author

Currently it is almost 10 PM local time here, but it is first on my list for tomorrow morning! (8 AM UTC+1)

@navaronbracke
Copy link
Collaborator Author

Version 6.0.0 has been published to Pub.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoogleDataTransport version conflict with firebase_crashlytics
3 participants