-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump MLKit to 7.0.0 #1206
fix: bump MLKit to 7.0.0 #1206
Conversation
cc @juliansteenbakker for second thought on the version number. We do need to update the minimum iOS version here. |
I would prefer a new major version, since this is a breaking change. People that have pinned older versions of firebase could still use the current version without problems. So if we publish this as 5.2.4 or 5.3.0, we would break those instances. On the other hand, lots of builds are failing right now, and if we publish this as a major version, a regular |
Because this only affects people using firebase_ packages, lets stick to a new major version 6.0.0. People without firebase_ packages won't be affected by the issue, and this update could break that. |
@juliansteenbakker Agreed, updated the version to 6.0.0 and also added a note about the minimum XCode version in the changelog. (is mentioned in the MLKit release notes) |
Great! LGTM! |
@navaronbracke Thanks for your work! Will the new version be published to Pub today? |
Currently it is almost 10 PM local time here, but it is first on my list for tomorrow morning! (8 AM UTC+1) |
Version 6.0.0 has been published to Pub.dev |
This PR updates MLKit to the latest release, which fixes dependency issues with other dependencies, such as Firebase.
However, due to MLKit requirements, the iOS minimum deployment target has been changed from 12.0 to 15.5.0.
See https://developers.google.com/ml-kit/release-notes#improvements for context.
Fixes #1165