Merge pull request #1059 from navaronbracke/fix_samples

fix: Adjust autoStart values for samples
juliansteenbakker · May 15, 2024 · c2c9848 · c2c9848
2 parents a2a4dd8 + b0d6f98
commit c2c9848
Show file tree

Hide file tree

Showing 11 changed files with 10 additions and 58 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 5.1.1
+* This release fixes an issue with automatic starts in the examples.
+
 ## 5.1.0
 This updates reverts a few breaking changes made in v5.0.0 in order to keep things simple.
 

diff --git a/example/lib/barcode_scanner_controller.dart b/example/lib/barcode_scanner_controller.dart
@@ -16,12 +16,9 @@ class BarcodeScannerWithController extends StatefulWidget {
 class _BarcodeScannerWithControllerState
     extends State<BarcodeScannerWithController> with WidgetsBindingObserver {
   final MobileScannerController controller = MobileScannerController(
-    torchEnabled: true, useNewCameraSelector: true,
-    // formats: [BarcodeFormat.qrCode]
-    // facing: CameraFacing.front,
-    // detectionSpeed: DetectionSpeed.normal
-    // detectionTimeoutMs: 1000,
-    // returnImage: false,
+    autoStart: false,
+    torchEnabled: true,
+    useNewCameraSelector: true,
   );
 
   Barcode? _barcode;

diff --git a/example/lib/barcode_scanner_listview.dart b/example/lib/barcode_scanner_listview.dart
@@ -15,20 +15,8 @@ class BarcodeScannerListView extends StatefulWidget {
 class _BarcodeScannerListViewState extends State<BarcodeScannerListView> {
   final MobileScannerController controller = MobileScannerController(
     torchEnabled: true,
-    // formats: [BarcodeFormat.qrCode]
-    // facing: CameraFacing.front,
-    // detectionSpeed: DetectionSpeed.normal
-    // detectionTimeoutMs: 1000,
-    // returnImage: false,
   );
 
-  @override
-  void initState() {
-    super.initState();
-
-    controller.start();
-  }
-
   Widget _buildBarcodesListView() {
     return StreamBuilder<BarcodeCapture>(
       stream: controller.barcodes,

diff --git a/example/lib/barcode_scanner_pageview.dart b/example/lib/barcode_scanner_pageview.dart
@@ -13,17 +13,10 @@ class BarcodeScannerPageView extends StatefulWidget {
 }
 
 class _BarcodeScannerPageViewState extends State<BarcodeScannerPageView> {
-  final MobileScannerController controller =
-      MobileScannerController(autoStart: false);
+  final MobileScannerController controller = MobileScannerController();
 
   final PageController pageController = PageController();
 
-  @override
-  void initState() {
-    super.initState();
-    unawaited(controller.start());
-  }
-
   @override
   Widget build(BuildContext context) {
     return Scaffold(

diff --git a/example/lib/barcode_scanner_returning_image.dart b/example/lib/barcode_scanner_returning_image.dart
@@ -18,19 +18,9 @@ class _BarcodeScannerReturningImageState
     extends State<BarcodeScannerReturningImage> {
   final MobileScannerController controller = MobileScannerController(
     torchEnabled: true,
-    // formats: [BarcodeFormat.qrCode]
-    // facing: CameraFacing.front,
-    // detectionSpeed: DetectionSpeed.normal
-    // detectionTimeoutMs: 1000,
     returnImage: true,
   );
 
-  @override
-  void initState() {
-    super.initState();
-    controller.start();
-  }
-
   @override
   Widget build(BuildContext context) {
     return Scaffold(

diff --git a/example/lib/barcode_scanner_window.dart b/example/lib/barcode_scanner_window.dart
@@ -17,13 +17,6 @@ class _BarcodeScannerWithScanWindowState
     extends State<BarcodeScannerWithScanWindow> {
   final MobileScannerController controller = MobileScannerController();
 
-  @override
-  void initState() {
-    super.initState();
-
-    controller.start();
-  }
-
   Widget _buildBarcodeOverlay() {
     return ValueListenableBuilder(
       valueListenable: controller,

diff --git a/example/lib/barcode_scanner_zoom.dart b/example/lib/barcode_scanner_zoom.dart
@@ -22,12 +22,6 @@ class _BarcodeScannerWithZoomState extends State<BarcodeScannerWithZoom> {
 
   double _zoomFactor = 0.0;
 
-  @override
-  void initState() {
-    super.initState();
-    controller.start();
-  }
-
   Widget _buildZoomScaleSlider() {
     return ValueListenableBuilder(
       valueListenable: controller,

diff --git a/example/lib/mobile_scanner_overlay.dart b/example/lib/mobile_scanner_overlay.dart
@@ -15,12 +15,6 @@ class _BarcodeScannerWithOverlayState extends State<BarcodeScannerWithOverlay> {
     formats: const [BarcodeFormat.qrCode],
   );
 
-  @override
-  void initState() {
-    super.initState();
-    controller.start();
-  }
-
   @override
   Widget build(BuildContext context) {
     final scanWindow = Rect.fromCenter(

diff --git a/ios/mobile_scanner.podspec b/ios/mobile_scanner.podspec
@@ -4,7 +4,7 @@
 #
 Pod::Spec.new do |s|
   s.name             = 'mobile_scanner'
-  s.version          = '5.0.2'
+  s.version          = '5.1.1'
   s.summary          = 'An universal scanner for Flutter based on MLKit.'
   s.description      = <<-DESC
 An universal scanner for Flutter based on MLKit.

diff --git a/macos/mobile_scanner.podspec b/macos/mobile_scanner.podspec
@@ -4,7 +4,7 @@
 #
 Pod::Spec.new do |s|
   s.name             = 'mobile_scanner'
-  s.version          = '5.0.2'
+  s.version          = '5.1.1'
   s.summary          = 'An universal scanner for Flutter based on MLKit.'
   s.description      = <<-DESC
 An universal scanner for Flutter based on MLKit.

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: mobile_scanner
 description: A universal barcode and QR code scanner for Flutter based on MLKit. Uses CameraX on Android, AVFoundation on iOS and Apple Vision & AVFoundation on macOS.
-version: 5.1.0
+version: 5.1.1
 repository: https://github.com/juliansteenbakker/mobile_scanner
 
 screenshots: