Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to SnoopCompile v3 #21

Closed
wants to merge 1 commit into from
Closed

Adapt to SnoopCompile v3 #21

wants to merge 1 commit into from

Conversation

schillic
Copy link

Closes #18 (I think).

The fix was pretty simple: @snoopr was renamed to @snoop_invalidations (see NEWS.md).

@fingolfin
Copy link
Contributor

But the new version requires Julia 1.10. We don't control which Julia version is used to execute this action, do we? Of course the recommended usage example in README suggests to use

    - uses: julia-actions/setup-julia@v1
      with:
        version: '1'

So perhaps follows that and we are fine?

@fingolfin
Copy link
Contributor

In any case, it's probably best to just merge this ASAP, as it breaks zillions of CI workflows everywhere, and then sort out finer details later.

@SaschaMann would you mind merging this and updating the tags?

@DilumAluthge
Copy link
Member

It seems like the immediate fix should be to modify the Pkg.add statement in this action to install SnoopCompile v2, right? Then this won't have any impact on the Julia version compatibility.

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should first do #22 as the immediate fix.

@schillic
Copy link
Author

Fair enough. Thanks for the quick fix!

@schillic schillic closed this Jul 25, 2024
@schillic
Copy link
Author

Note that the link to @snoopr in the README is still broken.

@DilumAluthge
Copy link
Member

Note that the link to @snoopr in the README is still broken.

Good catch! #29

@schillic schillic mentioned this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SnoopCompile v3
3 participants