Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update models.tsp #549

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

chore: update models.tsp #549

wants to merge 4 commits into from

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Oct 2, 2024

overriden -> overridden


Important

Fixes typo in comment within FunctionDef model in models.tsp.

  • Typo Fix:
    • Corrects typo in comment within FunctionDef model in models.tsp: "overriden" to "overridden".

This description was created by Ellipsis for 5fe7336. It will automatically update as commits are pushed.

overriden -> overridden
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5fe7336 in 6 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. typespec/tools/models.tsp:35
  • Draft comment:
    Typo fix: 'overriden' corrected to 'overridden'. This is a straightforward correction.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR is a simple typo fix, changing 'overriden' to 'overridden'. This is a straightforward correction and does not introduce any logical, performance, or security issues.

Workflow ID: wflow_eF7svdWbGIkvjIzd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@eltociear eltociear mentioned this pull request Oct 2, 2024
@creatorrr
Copy link
Contributor

@eltociear awesome! can you also please add a github action that runs bash scripts/generate_openapi_code.sh on push ?

@eltociear
Copy link
Contributor Author

@creatorrr
Is the following correct?

1176d23

@creatorrr
Copy link
Contributor

No, you'd have to install all of the dependencies needed (npm, typescript, python, poetry, agents_api dependencies) and then make sure that the result is committed back. Something like this:

      - uses: actions/setup-python@v5
        with:
          python-version: "3.12"

      - name: Install and configure Poetry
        uses: snok/install-poetry@v1

      - name: Configure Poetry to use .venv
        run: |
          cd agents-api
          poetry config virtualenvs.in-project true

      - name: Cache Poetry virtualenv
        uses: actions/cache@v4
        with:
          path: agents-api/.venv
          key: ${{ runner.os }}-agents-api-poetry-${{ hashFiles('agents-api/poetry.lock') }}
          restore-keys: |
            ${{ runner.os }}-agents-api-poetry-

      - name: Install dependencies
        run: |
          cd agents-api
          poetry install

      ### Install npm / typespec etc
      
      ### Run the script after this

      - uses: stefanzweifel/git-auto-commit-action@v4
        with:
          commit_message: "refactor: Lint agents-api (CI)"
          branch: ${{ github.head_ref }}

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants