Allow use of ssh-agent instead of mounting SSH key #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've cleaned up the PR to make the change as minimal as possible while providing useful command options to the README.md. |
|
I've updated the example in the docs to use the user's ${SSH_AUTH_SOCK} env var instead of hard-coding the path. This works in WSL (Ubuntu:22.04 with docker integration enabled); as well as on a Mac, so it's more cross-platform now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mounting an SSH key into the docker-ssh-tunnel container requires that it be unprotected by a passphrase, or for the passphrase to be stored in the container config. This is insecure.
As an alternative, this change allows the user to forward their ssh key agent SSH_AUTH_SOCK into the container. When this environment variable is defined, the ssh command in run.sh will not attempt to use a private key file, but instead will use the default behaviour of looking for an agent socket at the path ${SSH_AUTH_SOCK}.
Successfully tested on Docker Desktop for Mac.