Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate most LD_LIBRARY_PATH from install.sh. #33

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

gwtnb
Copy link
Member

@gwtnb gwtnb commented Mar 5, 2015

Use rpath to find libraries instead of LD_LIBRARY_PATH.
Why LD_RUN_PATH is not used is that ld.gold does not recognize LD_RUN_PATH for now.
https://sourceware.org/bugzilla/show_bug.cgi?id=13764

jubatus/jubatus#943

Use rpath to find libraries instead of LD_LIBRARY_PATH.
Why LD_RUN_PATH is not used is that ld.gold does not recognize LD_RUN_PATH for now.
https://sourceware.org/bugzilla/show_bug.cgi?id=13764
@kmaehashi
Copy link
Member

I'll confirm this. We need to add this to the packaging tool too.

Is it OK to close #32 once this got merged?

@kmaehashi kmaehashi self-assigned this Mar 5, 2015
@kmaehashi kmaehashi added this to the 0.7.1 milestone Mar 19, 2015
@kmaehashi
Copy link
Member

Specifying -p option cause error on apr-utils installation.

$ ./install.sh -p /home/jubatus/rpath-test
... snip ...
/usr/bin/install -c -m 644 ./lib/expat.h /home/jubatus/rpath-test/include/apr-1
make[1]: Leaving directory `/home/jubatus/Development/jubatus-installer/download/apr-util-1.5.4/xml/expat'
/bin/sh /home/jubatus/rpath-test/build-1/libtool --mode=install /usr/bin/install -c -m 755 libaprutil-1.la /home/jubatus/rpath-test/lib
libtool: install: error: cannot install `libaprutil-1.la' to a directory not ending in /home/jubatus/local/lib
make: *** [install] Error 1

@gwtnb
Copy link
Member Author

gwtnb commented Mar 19, 2015

Such error does not appear on my environment.
Could you re-run with -p after removing your download directory?

@gwtnb
Copy link
Member Author

gwtnb commented Mar 19, 2015

./waf --checkall seems to ignore LINKFLAGS which is specified at ./waf configure.

@kmaehashi kmaehashi modified the milestones: 0.7.2, 0.7.1 Apr 6, 2015
@kmaehashi kmaehashi modified the milestones: 0.7.2, Near Future Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants