feat: support client verify for derp (add integration tests) #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcticLampyrid
requested review from
ohdearaugustin,
juanfont and
kradalby
as code owners
ArcticLampyrid
force-pushed
the
verify-client
branch
from
a3839a5
to
ffd0a01
Compare
|
Thank you very much for your work! I have been a bit busy lately, and it would be great if you could help push this matter forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1953
By implementing
/verifyendpoint, derper can verify whether the client is in the node list of Headscale by specifying the--verify-client-urlparameter to/verifyin Headscale.This is a continued work on PR #1957, which includes integration testing to meet Headscale's merge requirements.
I am willing to participate in updating the related documentation and change logs, if needed. (Of course, I believe @117503445 is also willing)