#841: Support parsing a field as an SQL array. #854
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jtv
force-pushed
the
841-field-as-array
branch
2 times, most recently
from
050af51
to
f517fa8
Compare
| /// Parse the field as an SQL array. | ||
| /** Call the parser to retrieve values (and structure) from the array. | ||
| * | ||
| * Make sure the @ref result object stays alive until parsing is finished. If | ||
| * you keep the @ref row of `field` object alive, it will keep the @ref | ||
| * result object alive as well. | ||
| */ | ||
| [[deprecated( |
There was a problem hiding this comment.
I'm not sure about this deprecation. Looks like pqxx::array doesn't allow move and extraction to an external structure, which could be useful. Otherwise looks great
There was a problem hiding this comment.
Thanks. I suppose we could consider supporting moves, if we find a good use for them. But when are they really worthwhile? Perhaps if the array elements were of a custom time which in turn contained an array, or something like that.
Same consideration for extraction to an external structure: when is that helpful? You can copy elements right now. Or just keep the pqxx::array object as the basic storage for that data.
There was a problem hiding this comment.
@fallenworld1 for now if you don't mind I think I'll just merge this, and then make any incremental improvements as needed.
|
It's great to have several members of the community look into this. This level of involvement can save us from design mistakes that may creep in if I just do things on my own. We've got some suggestions for future improvements — notably on getting the data out and into some other data structure more efficiently. I think the easiest thing we could do about that is to support non- |
Adds a
fieldmember function,as_sql_array(), which reads an SQL array value into apqxx::array.