Skip to content

Commit

Permalink
Merge pull request #100 from jts/1.9-rc
Browse files Browse the repository at this point in the history
1.9 rc
  • Loading branch information
rdeborja authored May 6, 2022
2 parents b08bc23 + d36647c commit 2aff16f
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 7 deletions.
14 changes: 14 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,20 @@ Variant annotation output can be found in `qc_annotation` and the recurrent
amino acid change heatmap can be found in `plots/<prefix>_aa_mutation_heatmap.pdf`.


## Pangolin Version 4
Pangolin version 4 included several changes which required updates
to the `ncov-tools` environment. By default, `ncov-tools` will run pangolin
4 and will require changes to `ncov-parser` version 1.9 to parse the output
and populate the summary QC file.

Backward compability with Pangolin 3 is available and will require the following
parameter addition in the `config.yaml` file:
```
pangolin_version: "3"
```
Note that the specific version is not required, only if it is "3" or "4".


## Credit and Acknowledgements

* The tree-with-SNPs plot was inspired by a plot shared by Mads Albertsen.
Expand Down
2 changes: 1 addition & 1 deletion VERSION.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v.1.8.0
v.1.9.0
7 changes: 3 additions & 4 deletions workflow/envs/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@ dependencies:
- usher
- pip:
- dendropy>=4.4.0
- pyvcf
- pyvcf3
- ncov-parser
- git+https://github.com/hCoV-2019/lineages.git
- git+https://github.com/hCoV-2019/pangolin.git
- git+https://github.com/cov-lineages/pangolin.git
- git+https://github.com/cov-lineages/pangolin-data.git
- git+https://github.com/cov-lineages/constellations.git
- git+https://github.com/cov-lineages/scorpio.git
- git+https://github.com/cov-lineages/pangolin-data.git
- git+https://github.com/jts/ncov-watch.git
5 changes: 3 additions & 2 deletions workflow/rules/analysis.smk
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ rule make_sample_qc_summary:
py_script="get_qc.py",
metadata_opt=get_qc_summary_metadata_opt,
platform_opt=get_platform_opt,
run_name_opt=get_run_name_opt
run_name_opt=get_run_name_opt,
pangolin_version_opt=get_pangolin_version_opt
shell:
"{params.py_script} --alleles {input.alleles} \
--coverage {input.samplecoverage} \
Expand All @@ -162,7 +163,7 @@ rule make_sample_qc_summary:
--sample {wildcards.sample} \
--lineage {input.lineagereport} \
--aa_table {input.aa_table} \
--mutations {input.watch} \
--mutations {input.watch} {params.pangolin_version_opt} \
--run_name {params.run_name_opt} > {output}"

# merge the per-sample summary files into the run-level report
Expand Down
9 changes: 9 additions & 0 deletions workflow/rules/common.smk
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,15 @@ def get_annotated_variants(wildcards):
def get_all_masked_consensus(wildcards):
return ["masked_fasta/{sample}.masked_consensus.fasta".format(sample=s) for s in get_sample_names()]

def get_pangolin_version_opt(wildcards):
if "pangolin_version" in config:
return "--pangolin_ver %s" % (config['pangolin_version'])
else:
return ""





# generate the amplicon-level bed file from the input primer bed
rule make_amplicon_bed:
Expand Down

0 comments on commit 2aff16f

Please sign in to comment.