tickets: remove need to setup end mission triggers #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoppins
force-pushed
the
feature-tickets-endmission
branch
from
6c8beb5
to
4878443
Compare
The markdown documentation generation in the Template class is rather common and makes more sense to put it in the Check class so it can be used by other systems.
With the ability to call the same set of functions the mission editor can call we are able to eliminate the need for campaign designers to setup end mission triggered on flags.
Instead of using the custom timing use the Timer class that is commonly tested.
The Check class provides the ability to embed documentation that can be auto generated. The class also provides a wide verity of types it already checks for without having to write these check functions over and over again.
Before this change the whole ticket configuration would be saved to the state file. This made modifying the ticket configuration impossible mid campaign which makes campaign balancing an issue. With this change only the current ticket count and the original ticket start values are saved to the state file. All modifiers and difficulty can be modified by stopping the server, modifying the difficulty, and reloading the state file.
jtoppins
force-pushed
the
feature-tickets-endmission
branch
from
e7cde2f
to
10f7053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ability to call the same set of functions the mission editor can call we are able to eliminate the need for campaign designers to setup end mission triggered on flags.