Add transparency feature #164
Conversation
|
Why is this PR not merged? |
|
I would prefer a more complete approach. If we enable transparency it would have its own slider from 0 to 100. Maybe 50% for you would not mean transparent for other users. |
src/application.c
Outdated
| @@ -119,6 +126,7 @@ static void action_update_color_state(struct swappy_state *state, double r, | |||
| state->settings.g = g; | |||
| state->settings.b = b; | |||
| state->settings.a = a; | |||
| if (state->config->transparent) state->settings.a *= 0.5; | |||
There was a problem hiding this comment.
This is just too much "magic number". Transparency, once enabled, should be configurable by the user.
kadamski
force-pushed
the
transparency
branch
from
58b4330
to
eb6cfd9
Compare
It is sometimes better if the drawing is not fully covering the picture but is semi-transparent. This patch adds a simple button to enable transparency. When this button is enabled, everything will be drawn with 50% alpha channel.
kadamski
force-pushed
the
transparency
branch
from
eb6cfd9
to
d64e183
Compare
This commit adds UI elements and config option for configuring the transparency value. The default value is 50% but it can be changed in the 5% - 95% range in 10% steps.
kadamski
force-pushed
the
transparency
branch
from
d64e183
to
f2b703c
Compare
|
Ok, it took me a moment to make linter workflow happy. I didn't trigger it earlier so I didn't know it exists. I have added a new commit that implements configuration of transparency as you requested. I have left the previous commit as is with only tiny fix in src/config.h line 290 where I'm using correct default value define now. I didn't want you to have to review everything again and I think the first commit is somewhat self contained. But feel free to squash both commits if you prefer it that way. It looks like this: |
It is sometimes better if the drawing is not fully covering the picture but is semi-transparent. This patch adds a simple button to enable transparency. When this button is enabled, everything will be drawn with 50% alpha channel.