Test #5
Open
Test #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ES#10275) * Fix clickable area / cursor related issues * Update snapshot
…TES#10271) * Update CSEET href link * Add questionId to csv download method * Add download event emitter to base classes * Add download event emitter to question text * Add handling of download to response views * Add handling of download to specific view * Add handling of download to root page * Style question text with info * Update snapshots and fix lint issues * Standardize styles and add period to comments * Remove download question event from group views * Add optional tooltip to question text * Update snapshots * Remove unintended changes Co-authored-by: Ahmed Bahajjaj <[email protected]>
* Fix instructor student search as admin * Move entity param validation to execute
* Add encryption to API output * Add decryption to API endpoints * Update tests for encryption and decryption
…10270) * Add API for email request * Add frontend buttons for email feature * Test fix * Rename generateemail endpoint to email * Change auth type Co-authored-by: Ahmed Bahajjaj <[email protected]> * Link EmailType from backend to frontend * Change params of getEmail * Fix year not showing * Refactor data shape returned by generating strings to display * Remove comment * Move formatProperties to searchservice.ts * Change error message for unaccepted email type * Abstration for email opening link * Lint fix * Fix bad merge * Remove useless enum Co-authored-by: Ahmed Bahajjaj <[email protected]>
…help page componenets (TEAMMATES#10276) * npm run test passes, need to fix according to lint test output * fixed styling to pass the lint test. passes npm run test too * worked on instructor-help-sessions-section component, passes lint and componenet tests * worked on instructor-hel-students-section (refactoring properties), passes lint and component tests * resolved merge conflict Co-authored-by: Kon Yoo <[email protected]>
* Add skeleton for new collapse * Convert old collapse animations to use new ones * Add collapse animations for multiple places * Update snapshots * Lint fix * Fix E2E by adding timer for animation to play * Indentation fix * Change animation waiting method
) * Show error details on submit * Change map type to be more accurate, add comment to explain map Co-authored-by: Ahmed Bahajjaj <[email protected]>
…EAMMATES#10290) * Change SortBy constants for numerical scale * Add tests for comparing floats * Add compare float method * Shift floating point related SortBy constants * Change method name and simplify implementation
…TEAMMATES#10289) * Fix checkbox margins for small displays * Fix overflow of dropdown button in feedback path and visibility * Revert "Fix overflow of dropdown button in feedback path and visibility" This reverts commit 05de3c1. * Add css class to enable button shrinking * Updated question-edit-form.component.spec.ts.snap Co-authored-by: Nic <[email protected]> Co-authored-by: t-cheepeng <[email protected]>
…404 to 204 (TEAMMATES#10296) * Fix student short name/email wrongly hidden for student-instructor caller * Add empty ImageResult response object * Change status code for no response comment to 204 * Add check in getting student profile for when student is not found
* Remove googleId from StudentData output * Refactor frontend use of JoinState
…TES#10306) * Fix CollapseAnim bug causing element cut off * Update snapshots * Remove unnecessary styling in animate
…0310) * Fix flaky StudentCourseDetailsPageE2ETest * Update snapshots
…EAMMATES#10301) * Adds "Discard" button to session edit * Removes unnecessary change. * Added warning modal and tooltip * Update package.json * Changes modal text to match others * Removes call to backend, instead stores session instructions locally on clicking "Edit" * fixes linting issues * Uses getSessionEditFormModel to update form * tslint ignores no null assertion for one line * Removed Map for FeedbackSession * Renamed variables and updated comments * Renamed cancel event and handler * renamed functions and variables * Change feedbackSessionModelBeforeEditing to model * Refactor edit model in subscription Co-authored-by: Xiao Pu <[email protected]> * Implement deep copy of session model Co-authored-by: martinoamigo <[email protected]> Co-authored-by: Xiao Pu <[email protected]>
…EAMMATES#10282) * refactor search service (before modifying component test) * modified the component tests * changed naming convention more intuitively * fixed the component tests regarding sections * deleted the declaration of SearchStudentsTable and modified getPrivileges for performance improvement * specified type of privileges and used Record for performance improvement * replaced for loops with forEach Co-authored-by: t-cheepeng <[email protected]>
* Fix wrong redirect for registered user accessing public submission/result page * Do not disable submission forms during preview mode * Handle floating point division error for numscale question validation * Change min amount of MSQ selectable choices to 1 * Fix instructor search page not working when not both checkboxes are ticked * Add timezone offset information for edit course page * Show all possible instructor roles only when editing * Add mobile rubric submission form
…10288) * Add sort by to student home page * Add default sort to instructor course page * Add comment sort by last edited date * Add initial sorting to sortable table * Add sorting to instructor home, session, student * Update snapshots and fix lint issues * Fix instructor home page * Fix instructor course page E2E test * Specify initial sort more explicitly * Change loadFeedbackSession to use index * Move comment sorting to root page * Remove sorting from CUD and sort by creation date * Change sortCoursesEvent to be called at the end * Fix E2E tests for instructor course page
…10295) * Remove instructor googleId from output * Change access control to appropriate permission
…EAMMATES#10320) * Hide weights from students in FeedbackQuestionData * Update javadoc description * Hide other weights by setting to zero
* Optimize student pages for mobile * Optimize instructor related pages for mobile * Optimize components for mobile
…TES#10313) * add custom httpparameter encode and url encoder to accept plus sign * add test for custom url serializer * update method doc * update doc * Clean up docs * Refactor CustomEncoder to use HttpUrlEncodingCodec * Update method reference link * Enforce type parameters Co-authored-by: crizyli <[email protected]>
…ATES#10709) * Refactor search result for instructor search * Migrate tests to instructor search component from search service * Fix test Co-authored-by: Zongran Mo <[email protected]> Co-authored-by: Ahmed Bahajjaj <[email protected]>
… a better error message (TEAMMATES#10733) * Updated the error message for non-existent session and redirected to student home page * Addressed The requested changes TEAMMATES#10664
…MATES#10763) Co-authored-by: Ahmed Bahajjaj <[email protected]>
…tive To field (TEAMMATES#10762) Co-authored-by: Abhijit Roy <[email protected]> Co-authored-by: Ahmed Bahajjaj <[email protected]>
…S#10740) * Remove teammates* from class name * Add toJson method without pretty printing * Use CDN for CSS files * Do not include usermap in sitemap
…MATES#10555) * Implement feedback session copy to multiple courses * Bind input property to copyToCourseSet * Change copy session requests to use forkJoin * Add forkJoin error handling and update by model * Refactor copy session methods for modularity * Fix accidental regression * Refactor for code quality
…#10771) Co-authored-by: Abhijit Roy <[email protected]> Co-authored-by: Ahmed Bahajjaj <[email protected]>
…tabs (TEAMMATES#10777) * Change admin page to allow for tab separated instructor adding * 10568: add tests for admin home page change Co-authored-by: Si Tang <[email protected]> Co-authored-by: Ahmed Bahajjaj <[email protected]>
…10775) * Add maintenance return code for API server * Add under maintenance page
…MMATES#10779) * Add InstructorCourseStudentDetailsPageE2ETest * Check for text instead of not-specified element
…0766) * Add InstructorCourseDetailsPageE2ETest * Use System.lineSeparator to make test work across OS * Fix spacing * Clean up code * Add section test data
…rds page E2E tests (TEAMMATES#10796)
…n edit mode (TEAMMATES#10799) * Change the state of the edit feedback session into edit mode after routing to edit feedback session * Return isEditingMode declaration to false
…wn even if the link is correct (TEAMMATES#10807)
…ge (TEAMMATES#10800) * Fix cannot hide statistics bug * Fix inconsistent naming of no specific team * Fix section filtering bug
jtankw3
force-pushed
the
test
branch
3 times, most recently
from
f656d37 to
b1f72d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.