[TEAMMATES#10580] Student view team page: Loading Indicator for loadi…

…ng teammates not centralised (TEAMMATES#10790) * centralised loading indicator on Student view team page TEAMMATES#10580 * fixed indidation for solution that centralized Student view team page loading indicator TEAMMATES#10790 * fixed indidation for solution that centralized Student view team page loading indicator TEAMMATES#10790 * snap updated after fixing indentation for solution in PR 10790 Co-authored-by: Ahmed Bahajjaj <[email protected]>
jtankw3 · Nov 3, 2020 · 0035a68 · 0035a68
1 parent e7d18b0
commit 0035a68
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 26 deletions.
diff --git a/...dent-course-details-page/__snapshots__/student-course-details-page.component.spec.ts.snap b/...dent-course-details-page/__snapshots__/student-course-details-page.component.spec.ts.snap
@@ -29,31 +29,21 @@ exports[`StudentCourseDetailsPageComponent should snap when all data are still l
     
     
     
-  </tm-loading-retry><div
-    class="section"
-  >
+  </tm-loading-retry><tm-loading-spinner>
     <div
-      class="row top-padded"
+      class="loading-container"
     >
-      
-      
-      <tm-loading-spinner>
-        <div
-          class="loading-container"
-        >
-          <div
-            class="row spinner-border text-primary"
-            role="status"
-          />
-          <div
-            class="row text-secondary"
-          >
-            Loading...
-          </div>
-        </div>
-      </tm-loading-spinner>
+      <div
+        class="row spinner-border text-primary"
+        role="status"
+      />
+      <div
+        class="row text-secondary"
+      >
+        Loading...
+      </div>
     </div>
-  </div>
+  </tm-loading-spinner>
 </tm-student-course-details-page>
 `;
 
@@ -93,7 +83,6 @@ exports[`StudentCourseDetailsPageComponent should snap with default fields 1`] =
       class="row top-padded"
     >
       
-      
       <div
         class="col-md-10"
       >
@@ -366,7 +355,6 @@ exports[`StudentCourseDetailsPageComponent should snap with populated fields 1`]
           Your teammates:
         </strong>
       </div>
-      
       <div
         class="col-md-10"
       >

diff --git a/.../app/pages-student/student-course-details-page/student-course-details-page.component.html b/.../app/pages-student/student-course-details-page/student-course-details-page.component.html
@@ -85,12 +85,12 @@ <h5 class="d-inline"><strong> Sort By: </strong></h5>
   </div>
 </tm-loading-retry>
 
-<div class="section">
+<div class="section" *tmIsLoading="isLoadingTeammates">
   <div class="row top-padded">
     <div class="col-md-2" *ngIf="teammateProfiles.length">
       <strong>Your teammates:</strong>
     </div>
-    <div class="col-md-10" *tmIsLoading="isLoadingTeammates">
+    <div class="col-md-10">
       <table>
         <tbody>
         <tr *ngFor="let teammateProfile of teammateProfiles; let i = index">