Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement drain functionality, initial untested commit, DRAFT ONLY #1

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsudano
Copy link
Owner

@jsudano jsudano commented Oct 2, 2024

Details at nats-io#1325

@Jarema
Copy link

Jarema commented Oct 7, 2024

Hey.
Just to give you early feedback - I think it looks well.
Obviously requires quite a lot of testing.

@jsudano
Copy link
Owner Author

jsudano commented Oct 8, 2024

Awesome thank you, I'll get to writing tests then!

Is there a "development" doc for the repo? I've gathered that I need to manually run a NATS server locally before running cargo test, but I see test failures related to "no such file or directory" (even on master) when trying to run tests against that local NATS server. I'm assuming there's some setup step I'm missing.

@Jarema
Copy link

Jarema commented Oct 9, 2024

All you need to do is having nats-server available in you PATH.
The test suite will drive starting, cleaning up and shutting down the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants