-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delayed paperclip broken under paperclip 2.5.0 #58
base: master
Are you sure you want to change the base?
Conversation
…now we are back to use simple 'url' that calls the most_appropriate_url thru url_generator
Hi Marco, I have tried this patch, however I get the following error:
It seems |
ups sorry about that let me make sure I revert the most_appropriate_url completelly then |
@atd, giving this solution a little more thought the problem is that the default_url method of paperclip was moved to url_generator and now its private. still working on it. |
Any update on this? Upgrading to 3.2.1 and would love to continue using this :) |
https://github.com/aguilarsoto/delayed_paperclip this is what I end up doing if anyone wants to review it and get back to me. @atd your comments will be most appreciated |
Let me see if I can find some time to test it.. |
I'll test over the next couple days. |
Whats the status of this? Just wondering if anyone else should jump in to help or its too close to being pulled? |
@aguilarsoto I installed the other repository (referenced earlier) as a plugin and everything seemed to load fine. However, I'm not getting a delayed_job created for the background processing. Maybe I have something messed up... |
I've tested this too, updated to 2.7 paperclip, though the tests pass, when used in an app they never seem to reach a 'completed' stage, stalling at the 'saving image' phase. My guess is its not hitting the post processing method as in the past. I'll try and have a look soon. |
Update : My issue was mostly related to the combination with "paperclip-meta" gem, which is now resolved : teeparham/paperclip-meta#10 , I also wasnt sure about the use of UrlGenerator in that way, and just monkey patched it for now, but made notes on how it should be done properly later : #61 With both updates, confirmed to work on Rails 3.2.2 and Paperclip 2.7. |
Any plans to release this? |
Updated : Now on 3.1.2 : #69 |
Fix process jobs for models with default_scope
the 'most_appropriate_url' has being removed from the attachment and now we are back using simple 'url' calls and that calls most_appropriate_url from url_generator.
Regards,
Marco Aguilar