Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delayed paperclip broken under paperclip 2.5.0 #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

delayed paperclip broken under paperclip 2.5.0 #58

wants to merge 1 commit into from

Conversation

aguilarsoto
Copy link

the 'most_appropriate_url' has being removed from the attachment and now we are back using simple 'url' calls and that calls most_appropriate_url from url_generator.

Regards,
Marco Aguilar

…now we are back to use simple 'url' that calls the most_appropriate_url thru url_generator
@atd
Copy link

atd commented Jan 30, 2012

Hi Marco, I have tried this patch, however I get the following error:

wrong number of arguments (2 for 0)
/home/atd/dev/social_stream/documents/lib/delayed_paperclip/social_stream-documents.rb:37:in `url_with_processed'
/home/atd/.rvm/gems/ruby-1.9.2-p180/gems/paperclip-2.5.2/lib/paperclip/interpolations.rb:50:in `url'
/home/atd/.rvm/gems/ruby-1.9.2-p180/gems/paperclip-2.5.2/lib/paperclip/interpolations.rb:34:in `block (2 levels) in interpolate'
...

It seems url_with_processed takes several arguments.

@aguilarsoto
Copy link
Author

ups sorry about that let me make sure I revert the most_appropriate_url completelly then

@aguilarsoto
Copy link
Author

@atd, giving this solution a little more thought the problem is that the default_url method of paperclip was moved to url_generator and now its private. still working on it.

@nateleavitt
Copy link

Any update on this? Upgrading to 3.2.1 and would love to continue using this :)

@aguilarsoto
Copy link
Author

https://github.com/aguilarsoto/delayed_paperclip this is what I end up doing if anyone wants to review it and get back to me. @atd your comments will be most appreciated

@atd
Copy link

atd commented Feb 9, 2012

Let me see if I can find some time to test it..

@nateleavitt
Copy link

I'll test over the next couple days.

@tommeier
Copy link
Collaborator

Whats the status of this? Just wondering if anyone else should jump in to help or its too close to being pulled?

@nateleavitt
Copy link

@aguilarsoto I installed the other repository (referenced earlier) as a plugin and everything seemed to load fine. However, I'm not getting a delayed_job created for the background processing. Maybe I have something messed up...

@tommeier
Copy link
Collaborator

tommeier commented Mar 2, 2012

I've tested this too, updated to 2.7 paperclip, though the tests pass, when used in an app they never seem to reach a 'completed' stage, stalling at the 'saving image' phase. My guess is its not hitting the post processing method as in the past. I'll try and have a look soon.

@tommeier
Copy link
Collaborator

tommeier commented Mar 4, 2012

Update : My issue was mostly related to the combination with "paperclip-meta" gem, which is now resolved : teeparham/paperclip-meta#10 , I also wasnt sure about the use of UrlGenerator in that way, and just monkey patched it for now, but made notes on how it should be done properly later : #61

With both updates, confirmed to work on Rails 3.2.2 and Paperclip 2.7.

@phene
Copy link

phene commented Apr 17, 2012

Any plans to release this?

@tommeier
Copy link
Collaborator

tommeier commented Jul 2, 2012

Updated : Now on 3.1.2 : #69

malandrina pushed a commit to hoteltonight/delayed_paperclip that referenced this pull request Feb 21, 2014
Fix process jobs for models with default_scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants