Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kinesis #1

Open
wants to merge 86 commits into
base: V1.0
Choose a base branch
from
Open

Update kinesis #1

wants to merge 86 commits into from

Conversation

jstnjs
Copy link
Owner

@jstnjs jstnjs commented Aug 11, 2023

No description provided.

ReFil and others added 30 commits September 17, 2022 19:51
Remove DTS file listing requirement that was deprecated in teh move to Z3
Removed default brightness as that's handled by base firmware now
Added USB VID, PID and manufacturer ID
Enabled DCDC converter for marginally improved battery
* Cleanup layer binding formatting
    * Align rows/columns
    * Be consistent for each layer
    * Consistent with `keymap.json`
* Replace `BKSP` with `BSPC`
    * Based on https://zmk.dev/docs/codes/keyboard-keypad#control--whitespace
    * Consistent with `keymap.json`
* Replace default layer `&kp KP_NUMBER_*` with `&none`
    * These were `&none` in v1
    * Consistent with other layers
BT config uses a different field for the manufacturer name
Co-authored-by: Ed Flanagan <[email protected]>
New settings reset file fully erases the peripheral data from the central, vital for ble whitelisting feature
The warnings are:

* `Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout`
* `The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`
* `The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`
* `Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout`

Signed-off-by: Douglas Camata <[email protected]>
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout

Signed-off-by: Douglas Camata <[email protected]>
Upgrade Github Actions to avoid deprecations
This makes sure that all versions of podman can resolve the image
successfully
The file(s) being removed may not exist, but make shouldn't fail because
of it:

        $ make clean
        rm ./firmware/*.uf2
        rm: cannot remove './firmware/*.uf2': No such file or directory
        make: *** [Makefile:10: clean] Error 1
        $ echo $?
        2

this also removes leading ./ from path in clean, and assumes that `make
clean` is being run from the top level repo dir
support using podman or docker
makefile: ignore errors during clean
The target all was previous running setup followed by build.  As
both setup and build are phony targets they run in sequence and because
the firmware contain the timestamp they always run (dependencies doesn't
do anything).  all now does exactly what it says on the tin
without introducing non-standard targets.

clean now removes the images that created during build which is
what you expect from that target.  See:
https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html#Standard-Targets
ReFil and others added 30 commits September 7, 2023 09:09
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
* Minor cleanup, change date format, add beta testing

* Update CHANGELOG.md
Tweaks to point to new ZMK branch, changes to support this.
Improves reset performance after last minor ZMK update
* Improve documentation based on feedback

* Update README.md

* Update CHANGELOG.md
* Document new NKRO settings

* Update CHANGELOG.md
* Version compiled FW with hash

Auto generates a macro to type out version info, local and github compilation now includes commit hash and timestamp in final uf2 files

* Fix local builds

makefile doesn't like the script returning the macro, directed to null for local builds as version.dtsi file accessible
* Update keymap.json to reflect version macro

* Update CHANGELOG.md
* Make get_version use bash from $PATH

* Update CHANGELOG.md

---------

Co-authored-by: ReFil <[email protected]>
This reverts commit 18e664a.
This reverts commit 9fc6c62.
* Add pull request template

* Update CHANGELOG.md
…303)

* Prefer `tr` to ${char^^}, which does not work on older bash versions

* Update CHANGELOG.md

---------

Co-authored-by: ReFil <[email protected]>
- Enhance the Makefile to enable firmware building exclusively for the left side.

To modify the keymap, flashing only the left side's firmware suffices.

This change facilitates the creation of firmware for the left side only,
thereby expediting the build process.

Usage: make left

This update maintains existing functionality. Without specifying the
left target, firmware for both halves will be generated.

- Add separate make targets to clean firmware and docker image

Add targets clean_firmware and clean_image independently while maintaing clean to run both

- Ensure files modified by the build process are reset at the end

The current build process dynamically generates the content of the version macro
in config/version.dtsi to enable users to print out the precise version and commit
the firmware was built on via a keybinding on the keymap.

This change ensurs that the changes to this macro file are reset at the end of the
build process to ensure it isn't shown as modified and added to keymap commit changes.
In #376 a new step was introduced for local builds to undo changes
to the version.dtsi file after a build in order to reduce noise to the repo.

Unfortunately the way used to execute the step causes the version.dtsi
file to be reset too early and therefore causes an incorrect version
number to be used for the version macro when run locally. This went
unfortunately undiscovered as the checked in version.dtsi was the same
on the day the change in #376 was tested and was not noticed until
I build a new change to my keymap locally a few days ago.

The git command introduced in #376 is wrapped into a shell function.

However what was missed is that commands run by the shell function are run when
the function calls are expanded by make. This causes the version.dtsi file to be reset
before the firmware build process is even started which resultes in the version.dtsi
currently checked in to the repo to be used for local builds instead of the
newly generated file when make starts.

This change updates how the git command to reset the version.dtsi
is being called. It is no longer called within a shell function to ensure it
does run in the order it is defined after the firmware build is complete.

Builds run through GitHub actions are not impacted and always used the correct version.dtsi

For more information and context see:
  - https://www.gnu.org/software/make/manual/html_node/Shell-Function.html
  - https://www.gnu.org/software/make/manual/html_node/Reading-Makefiles.html
* Zephyr 3.5 update

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.