-
Notifications
You must be signed in to change notification settings - Fork 14
Added support for matching using context managers. #38
base: master
Are you sure you want to change the base?
Added support for matching using context managers. #38
Conversation
… "f_back"` error and missing return statement.
I think its only failing with the type checks. I'm not sure I broke something since the same errors appear to be part of existing issues. I'm not sure though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the idea and the pull request! I think this is pretty compelling.
I'm fairly short on time these days, so I'm afraid I can't help much in implementation, but I do believe all the tests pass before these changes (any tests expected to fail are marked as such and don't block CI). You may need to update the mypy plugin to support this new idiom.
Would you be willing to make those changes, so that it's all green? Then I'm more than happy to merge this! 😄
I'll have a look at it in the coming days. I have no experience developing mypy plugins, so it might take a while. |
Proposed implementation for the context manager based pattern matching described in issue #37