Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Added support for matching using context managers. #38

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aarondewindt
Copy link

Proposed implementation for the context manager based pattern matching described in issue #37

@aarondewindt
Copy link
Author

I think its only failing with the type checks. I'm not sure I broke something since the same errors appear to be part of existing issues. I'm not sure though.

Copy link
Owner

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the idea and the pull request! I think this is pretty compelling.

I'm fairly short on time these days, so I'm afraid I can't help much in implementation, but I do believe all the tests pass before these changes (any tests expected to fail are marked as such and don't block CI). You may need to update the mypy plugin to support this new idiom.

Would you be willing to make those changes, so that it's all green? Then I'm more than happy to merge this! 😄

@aarondewindt
Copy link
Author

aarondewindt commented May 16, 2020

I'll have a look at it in the coming days. I have no experience developing mypy plugins, so it might take a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants