Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About page #19

Open
wants to merge 7 commits into
base: algorithms-page
Choose a base branch
from
Open

About page #19

wants to merge 7 commits into from

Conversation

jsoules
Copy link
Owner

@jsoules jsoules commented Jul 14, 2021

This ports over the existing About page (Issue #6) and reworks it to be a series of markdown files vs. hard-coded HTML.

I also put some more time into debugging some of the styling issues, in the process porting over the header and footer from the existing SpikeForest site. And, good news, figured out that the bootstrap css was not getting imported--I have now imported that as part of the index.css. (There is likely a better way to do this, especially for content from a CDN, but I haven't figured out what it is yet). Adding this import fixes most of the display issues that we were having, with the exception that the text in the navigation sidebars is not displaying--the HTML is present and styles are updating according to scroll position as advertised, it's just there's no text there. So that will need some further troubleshooting.

This file should be merged into the other open PR #15 since it's branched off of that, prior to PR #15 being merged to main.

Open items:

  • Fix sidebar contents not being displayed
  • Implement a better pattern for how static markdown file content is getting imported & rendered
  • Implement a better pattern for linking the bootstrap css from CDN

These have been created as separate issues in this project.

This version is live on vercel at https://othismos-jsoules.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant