Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#62 Switch to platform options from deprecated custom schema options #64

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

sasa-b
Copy link
Contributor

@sasa-b sasa-b commented Aug 12, 2023

As suspected the issue in #62 was due to using the deprecated customSchemaOptions property.

Btw this package works with PostgreSQL 15 as well, I've just noticed I've been using it with that version all this time without any issues so far, although the highest officially supported version was 13.

@florimondmanca
Copy link

Hi @sasa-b

I'm seeing the same issue trying to upgrade to doctrine/orm 2.16.2. We get the error you mention in #62 while running symfony console doctrine:schema:validate after updating deps.

I installed this branch locally like so:

Edit composer.json:

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/sasa-b/doctrine-postgis"
        }
    ],
    "require": {
        "jsor/doctrine-postgis": "dev-migration-diff-fix"
    }
}

Then run symfony composer update to install and sync lock file.

I can confirm the error goes away and locally everything looks fine.

I looked at the code and I can only say "LGTM".

What can we do to move this forward? @jsor Would you be available for review?

@florimondmanca
Copy link

florimondmanca commented Sep 14, 2023

It seems the issue appears starting doctrine/orm 2.15.5

In this version, doctrine/orm started using platformOptions instead of customSchemaOptions

https://github.com/doctrine/orm/releases/tag/2.15.5

doctrine/orm#10855

We're pinning to < 2.15.5 for now, waiting for this PR to land

@TomAdam
Copy link

TomAdam commented Sep 15, 2023

I have the same issue here. Is any help needed to get this merged?

@ElGabbu
Copy link

ElGabbu commented Nov 30, 2023

@jsor would really appreciate if we could push this forward. It's somewhat of a blocker preventing us to move forward with new doctrine/orm versions. Many thanks for your time.

@tg-cbnmc
Copy link

It would be great to merge this PR. We also are stuck with doctrine/orm versions. Thanks a lot in advance!

@thePanz
Copy link

thePanz commented Feb 12, 2024

Isn't this related (or maybe fixed too) on #61 ?

@jsor jsor merged commit cabb595 into jsor:main Feb 20, 2024
@florimondmanca
Copy link

Thank you for merging @jsor 🙏

@ElGabbu
Copy link

ElGabbu commented Feb 20, 2024

@jsor many thanks for merging! ... Could we have a new tag?

@jsor
Copy link
Owner

jsor commented Feb 20, 2024

Thanks @sasa-b! Released in v2.3.0.

@sasa-b
Copy link
Contributor Author

sasa-b commented Feb 21, 2024

@jsor thanks for merging! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants