Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve boolean operator order of ops and grouping tests #83

Merged
merged 1 commit into from
Jun 18, 2024
Merged

improve boolean operator order of ops and grouping tests #83

merged 1 commit into from
Jun 18, 2024

Conversation

gregsdennis
Copy link
Collaborator

Found a few bugs in my implementation surrounding these, and discovered that the tests could be better.

@gregsdennis gregsdennis mentioned this pull request Jun 17, 2024
Merged
@gregsdennis gregsdennis requested review from glyn and f3ath June 17, 2024 21:59
f3ath
f3ath approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@f3ath f3ath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and passes on my impl.

@gregsdennis gregsdennis merged commit ad2ac85 into main Jun 18, 2024
2 checks passed
@gregsdennis gregsdennis deleted the gregsdennis/boolean-order-of-operations branch June 18, 2024 02:31
glyn
glyn reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glyn glyn glyn left review comments

@f3ath f3ath f3ath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregsdennis @glyn @f3ath