Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add quote escape tests for filter expressions #78

Merged
merged 2 commits into from
May 16, 2024
Merged

add quote escape tests for filter expressions #78

merged 2 commits into from
May 16, 2024

Conversation

gregsdennis
Copy link
Collaborator

@gregsdennis gregsdennis mentioned this pull request May 14, 2024
Merged
f3ath
f3ath reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@f3ath f3ath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass on my implementation. Any reason why these tests are negative? Seems like adding a positive match would also check that the escaped chars are not missed/mishandled.

@gregsdennis
Copy link
Collaborator Author

Any reason why these tests are negative?

Nope. Just forgot to update the data. Will do in a bit (probably tomorrow).

@gregsdennis
Copy link
Collaborator Author

@f3ath I've made some actual data to query.

@f3ath f3ath merged commit 0ddbb76 into main May 16, 2024
2 checks passed
@f3ath
Copy link
Collaborator

f3ath commented May 16, 2024

Looks good!

@gregsdennis gregsdennis deleted the gregsdennis/quote-escapes-in-expressions branch May 16, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f3ath f3ath f3ath left review comments

@He-Pin He-Pin He-Pin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregsdennis @f3ath @He-Pin