Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test I-Regexp mapping corner cases #77

Merged
merged 1 commit into from
May 13, 2024
Merged

Test I-Regexp mapping corner cases #77

merged 1 commit into from
May 13, 2024

Conversation

jg-rp
Copy link
Contributor

@jg-rp jg-rp commented May 10, 2024 •
edited
Loading

This PR covers some corner cases that might arise when mapping I-Regexp patterns to implementation-specific regex patterns.

@jg-rp jg-rp mentioned this pull request May 10, 2024
Merged
@jg-rp jg-rp marked this pull request as ready for review May 11, 2024 06:44
@gregsdennis
Copy link
Collaborator

Thanks for these. I'll run them through my implementation next week.

f3ath
f3ath approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@f3ath f3ath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes on my implementation

gregsdennis
gregsdennis approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug for me. 👍

@gregsdennis gregsdennis merged commit fc9449b into jsonpath-standard:main May 13, 2024
2 checks passed
@gregsdennis gregsdennis mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsdennis gregsdennis gregsdennis approved these changes

@f3ath f3ath f3ath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jg-rp @gregsdennis @f3ath