Cover existence tests in logical expressions #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
requested changes
Mar 11, 2024
tests/filter.json
Outdated
| { | ||
| "name": "exists and exists, data false", | ||
| "selector" : "$[[email protected]&&@.b]", | ||
| "document" : [{"a": false, "b": false}], |
There was a problem hiding this comment.
Can we add an item here that doesn't match?
There was a problem hiding this comment.
This test case has been updated to include non-matching data.
tests/filter.json
Outdated
| { | ||
| "name": "exists or exists, data false", | ||
| "selector" : "$[[email protected]||@.b]", | ||
| "document" : [{"a": false}, {"b": false}], |
There was a problem hiding this comment.
Non-matching data has been added to this test case, plus data that matches one side of the or expression.
jg-rp
force-pushed
the
logical-existence
branch
from
0647adf to
af48f89
Compare
gregsdennis
approved these changes
Mar 12, 2024
|
I'll run these in my lib tomorrow. Then I'll merge. |
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that singular filter queries are evaluated as existence tests when they are part of a logical expression, but not involving a comparison expression.
This was a bug for me. I was eagerly unwrapping singular node lists before evaluating comparison expression and logical expressions.