Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unevaluated* updates (and some annotation dependency cleanup) #1541

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gregsdennis
Copy link
Member

What kind of change does this PR introduce?

Updates for spec release

Issue & Discussion References

Summary

Updates the unevaluated* keywords and sections that reference them (e.g. "this keyword's annotation affects the behavior of this other keyword").

Does this PR introduce a breaking change?

@gregsdennis gregsdennis changed the title unevaluated* updaets (and some annotation dependency cleanup) unevaluated* updates (and some annotation dependency cleanup) Oct 12, 2024
@gregsdennis gregsdennis self-assigned this Oct 12, 2024
jsonschema-core.md Outdated Show resolved Hide resolved
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much, much clearer. I love this improvement. I always found annoying that keywords like these were defined so much on top of annotations.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this annotation dependency cleanup get done 🎉

jsonschema-core.md Outdated Show resolved Hide resolved
[in-place applicators](#in-place) defined in this document.

This keyword applies its subschema to any array elements which have not been
deemed "evaluated" per {{#unevaluated}}. Validation passes if the keyword's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is {{#unevaluated}} parsed/replaced here?

Copy link
Member Author

@gregsdennis gregsdennis Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's replaced with the section title and a link to the section.

@jdesrosiers can confirm.

Co-authored-by: Karen Etheridge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants