Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rfc2xml v3 #1372

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Upgrade to rfc2xml v3 #1372

merged 1 commit into from
Feb 26, 2023

Conversation

awwright
Copy link
Member

@awwright awwright commented Dec 26, 2022

This updates the syntax to the v3 vocabulary which is what the Markdown toolchain generates. This should be pulled in before #1369, #1370.

@gregsdennis
Copy link
Member

Just to be clear, are you saying that this should be pulled in first so that we can more easily see what the markdown changeover does?

@awwright
Copy link
Member Author

awwright commented Jan 1, 2023

To compare a Markdown document to an XML document, the xml2rfc toolchain can generate XML from Markdown, but it generates v3 XML. So with the current XML, lists and other things will mismatch. This is a long overdue upgrade anyways.

@awwright
Copy link
Member Author

This has been sitting for a considerable amount of time, it shouldn't change any of the output (except it fixes some whitespace output problems), and is easily fixed or reverted later on, so I'm going flag this for merge. May someone contribute an approval please?

@awwright awwright enabled auto-merge (rebase) February 24, 2023 19:32
@awwright awwright merged commit ab0453e into json-schema-org:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants