Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into openapi #1647

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Merge master into openapi #1647

merged 6 commits into from
Nov 27, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Nov 27, 2024

Merges the master branch into openapi, which provides IJsonApiEndpointFilter.
Eliminate JsonApiEndpoint enum, and use JsonApiEndpoints enum from the base library instead.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 91.55844% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.48%. Comparing base (9010f16) to head (11aafa4).
Report is 7 commits behind head on openapi.

Files with missing lines Patch % Lines
...etCore/Middleware/HttpMethodAttributeExtensions.cs 81.81% 3 Missing and 3 partials ⚠️
...JsonApiMetadata/JsonApiEndpointMetadataProvider.cs 87.50% 1 Missing and 1 partial ⚠️
...e.OpenApi.Swashbuckle/OpenApiEndpointConvention.cs 96.92% 0 Missing and 2 partials ⚠️
...ore/Controllers/BaseJsonApiOperationsController.cs 71.42% 1 Missing and 1 partial ⚠️
...pi.Swashbuckle/JsonApiMetadata/EndpointResolver.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1647      +/-   ##
===========================================
+ Coverage    90.46%   90.48%   +0.02%     
===========================================
  Files          459      461       +2     
  Lines        13938    13961      +23     
  Branches      2166     2172       +6     
===========================================
+ Hits         12609    12633      +24     
+ Misses         903      902       -1     
  Partials       426      426              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review November 27, 2024 18:38
@bkoelman bkoelman merged commit 68cad58 into openapi Nov 27, 2024
16 checks passed
@bkoelman bkoelman deleted the merge-master-into-openapi branch November 27, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant