Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct order of JSON:API members in generated swagger.json #1362

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

bkoelman
Copy link
Member

Corrects the order of members in top-level documents, links, and relationship objects.

Closes #1115.

QUALITY CHECKLIST

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1362 (e3dc622) into openapi (a420db9) will decrease coverage by 0.01%.
The diff coverage is 94.00%.

@@             Coverage Diff             @@
##           openapi    #1362      +/-   ##
===========================================
- Coverage    90.05%   90.05%   -0.01%     
===========================================
  Files          305      306       +1     
  Lines         9869     9888      +19     
  Branches      1659     1660       +1     
===========================================
+ Hits          8888     8905      +17     
- Misses         650      651       +1     
- Partials       331      332       +1     
Files Coverage Δ
...penApi/SwaggerComponents/JsonApiSchemaGenerator.cs 100.00% <100.00%> (ø)
...ggerComponents/ResourceFieldObjectSchemaBuilder.cs 99.01% <100.00%> (+0.06%) ⬆️
...SwaggerComponents/ResourceObjectSchemaGenerator.cs 93.65% <94.44%> (-0.47%) ⬇️
...enApi/SwaggerComponents/OpenApiSchemaExtensions.cs 75.00% <75.00%> (ø)

@bkoelman bkoelman marked this pull request as ready for review October 24, 2023 01:19
@bkoelman bkoelman merged commit 0709ea4 into openapi Oct 24, 2023
15 checks passed
@bkoelman bkoelman deleted the openapi-schema-structure branch October 24, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant