-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to resolve CSS var() #3299
base: main
Are you sure you want to change the base?
Conversation
Merging with master.
Merging with master before push
Would love if this got approved! 🙏 |
Any updates here? I've run into this issue as well, and would love to be able to stop using my workaround. |
@raymondwang I'm running into this issue too, I'm curious, what is your workaround? |
@hughockey I had something else in mind when I first left that comment (pulling the resolved variable value from the element and setting the value of the variable directly onto the element, and using a |
Any news ? |
any progress here? I'm planning on adopting vanilla-extract for a new project but it heavily relies on CSS variables for dynamic styling which then renders those aspects of the styling untestable through RTL + |
any updates on this? this PR is like 2 years old |
I would be interested in any news on the subject. |
Any update here? It's been 2 years since opening this PR! |
Also waiting for the merge. |
Any update on this? We are facing problems with |
Implements this spec:
https://drafts.csswg.org/css-variables-1/
Includes standard substitution, dependency cycles, and inheritance. I've hooked in the new css/css-variables WPT tests directory and made sure I didn't cause any new failures. Still looks like there's some work to do regarding parsing custom properties and the "var()" function in cssstyle. I've added notes to to-run.yml in places where I was pretty sure the problem was there.
This pull request can be standalone, but it probably works better if it's included with one of these requests from cssstyle:
jsdom/cssstyle#127
jsdom/cssstyle#140